Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update resource_context.go #585

Closed
wants to merge 1 commit into from
Closed

Update resource_context.go #585

wants to merge 1 commit into from

Conversation

maxehio
Copy link

@maxehio maxehio commented Nov 20, 2024 •
edited
Loading

Mentioned that a user can include autoattach if they are creating contexts via our TF provider

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

@maxehio
Update resource_context.go
5609a8a 
Mentioned that a user can include autoattach if they are creating contexts via our TF provider
@maxehio maxehio requested a review from a team November 20, 2024 18:49
peterdeme
peterdeme reviewed Nov 20, 2024
View reviewed changes
spacelift/resource_context.go
@@ -137,6 +137,7 @@ func resourceContext() *schema.Resource {
},
"labels": {
Type: schema.TypeSet,
Description: "To leverage the `autoattach` magic label, ensure your label follows the naming convention: `autoattach:<your-label-name>`"
Copy link
Contributor

@peterdeme peterdeme Nov 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Description: "To leverage the `autoattach` magic label, ensure your label follows the naming convention: `autoattach:<your-label-name>`"
Description: "Labels of the context. To leverage the `autoattach` magic label, ensure your label follows the naming convention: `autoattach:<your-label-name>`",

@peterdeme
Copy link
Contributor

I think you'll need to regenerate the docs too:
cd tools && go generate ./...

@peterdeme peterdeme requested a review from a team November 20, 2024 18:52
@peterdeme
Copy link
Contributor

peterdeme commented Nov 21, 2024 •
edited
Loading

Fixed it here @maxehio :
#586

@peterdeme peterdeme closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterdeme peterdeme peterdeme left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxehio @peterdeme